search

Fayob / portfolio-setup-project

This is my portfolio that involves the compilation of the project I have worked on, this exemplifies my passion, skills, qualifications, training and experiences. It provides insight into my personality and work ethic.
3 stars 0 forks source link

Deployed Portfolio Project #6

Closed Fayob closed 2 years ago

Fayob commented 2 years ago

https://fayob.github.io/portfolio-setup-project/

zhadier commented 2 years ago

Hi @Fayob 👋

Good job so far! 🌤️ There are some issues that you still need to work on to go to the next project but you are almost there! 🍓

Highlights

✔️Great job on the deployment

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question @zhadier so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Fayob commented 2 years ago

Please I don't understand and know where to add the link in the live demo, is it on my ReadMe file ?

zhadier commented 2 years ago

Please I don't understand and know where to add the link in the live demo, is it on my ReadMe file ?

Fayob commented 2 years ago

Alright, Thank you very much

1GORDON commented 2 years ago

Status: APPROVED 🟢

Hi @zhadier ✋

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! :tada: :clap: :clap: :100:

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.