search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Release 2.3.0 #118

Closed emmanuelmuturia closed 1 month ago

emmanuelmuturia commented 1 month ago

This PR documents the publishing of Release 2.3.0 and it also fixes #117 by adding some refinements to releaseArtMaker.sh and RELEASE.md...

Fbada006 commented 1 month ago

Is this tested @emmanuelmuturia ? If so, where?

emmanuelmuturia commented 1 month ago

Is this tested @emmanuelmuturia ? If so, where?

Here is a sample GitHub Release that I have just created to confirm that releaseArtMaker.sh works as expected: https://github.com/Fbada006/ArtMaker/releases/tag/untagged-307411caaa1098f34ba0

I had deleted the previous ones and forgot to leave the latest one after testing. As for Release 2.3.0, I ensured that the Publish Pipeline ran successfully but the changes have not yet been reflected on Maven Central...

Fbada006 commented 1 month ago

@emmanuelmuturia , your release cannot go through because the release version has not been updated in the scripts as explained in the release read me file. The version still points to 2.2.0 instead of 2.3.0. As much as you updated the read me to have the instructions for using your github release script, the previous instructions still apply.

emmanuelmuturia commented 1 month ago

@emmanuelmuturia , your release cannot go through because the release version has not been updated in the scripts as explained in the release read me file. The version still points to 2.2.0 instead of 2.3.0. As much as you updated the read me to have the instructions for using your github release script, the previous instructions still apply.

@emmanuelmuturia , your release cannot go through because the release version has not been updated in the scripts as explained in the release read me file. The version still points to 2.2.0 instead of 2.3.0. As much as you updated the read me to have the instructions for using your github release script, the previous instructions still apply.

I had incremented libVersion before pushing the changes and triggering publish.yml as seen here: https://github.com/Fbada006/ArtMaker/blob/release/2.3.0/scripts/publish.gradle.kts

I have modified the instructions to include this. Please let me know if there is something else that I may have not considered...

Fbada006 commented 1 month ago

This is okay. I had to re-trigger the release pipeline. I will look at the script in detail later.