search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Ktlint Exclusion (ArtMakerSharedPreferences.kt) #124

Closed emmanuelmuturia closed 1 month ago

emmanuelmuturia commented 1 month ago

Once the KMP Migration is complete, ArtMakerSharedPreferences.kt will need to be re-included in ktlint's scope of Static Analysis. This will be achieved by removing the following line from the project-level build.gradle.kts:

// To be removed after the KMP Migration... "src/commonMain/kotlin/com/fbada006/shared/data/ArtMakerSharedPreferences.kt",

emmanuelmuturia commented 1 month ago

@Fbada006 @CalebKL Since we are currently using DataStore to handle our preferences, will we still need ArtMakerSharedPreferences or will it just have to be deleted for this issue to be closed?

Fbada006 commented 1 month ago

Cleanup has been done @emmanuelmuturia . We do not keep unused classes. Go ahead and implement this

emmanuelmuturia commented 1 month ago

Cleanup has been done @emmanuelmuturia . We do not keep unused classes. Go ahead and implement this

ArtMakerSharedPreferences still exists as seen here: https://github.com/Fbada006/ArtMaker/blob/kmp-migration/shared/src/commonMain/kotlin/com/fbada006/shared/data/ArtMakerSharedPreferences.kt

Let me delete it as it is not in use anymore and refine the ktlint configuration to close this issue...