search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Added Overflow-Menu icons #22

Closed CalebKL closed 4 months ago

CalebKL commented 4 months ago

Added overflow menu which triggers a ModalBottomSheet Since we don't have a lot of items here on the bottom sheet, I though its best we use a row for the overflow menu items and limit BottomSheet drag (This can change though if we discuss and choose otherwise) Fixes #15

Fbada006 commented 4 months ago

One more thing, give the control bar some elevation as well so that the user can see that it is a different element. If the background of the bar is the same as the canvas, it almost looks like a single component instead of 2 composables.

CalebKL commented 4 months ago

One more thing, give the control bar some elevation as well so that the user can see that it is a different element. If the background of the bar is the same as the canvas, it almost looks like a single component instead of 2 composables.

I have made the changes, for the elevation I used shadowElevation from Surface Composable, there's also a tonalElevation as well, but I think shadow looks better

CalebKL commented 4 months ago

Please include a screenshot of the latest UI before you merge as I am curious to see how it differs from the one you had previously shown me...

I can attach the screenshot, but you can also have a look at it. Try git fetch --all on the terminal then checkout my branch and run. I think it would be easier? Wdyt?

emmanuelmuturia commented 4 months ago

@CalebKL Yes, that works. I was just curious to check it out as soon as possible...

CalebKL commented 4 months ago

@CalebKL Yes, that works. I was just curious to check it out as soon as possible...

Screenshot_1721929469 Screenshot_1721929472

emmanuelmuturia commented 4 months ago

@CalebKL So far so good. I see that you have merged the PR so let me work on my corrections...