search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Task/spotless config #28

Closed CalebKL closed 4 months ago

CalebKL commented 4 months ago

This PR adds Linting and Spotless header to the Project. There's also a task on the CI which runs the Lint and updates the Header. Fixes #10 :japanese_ogre: I have not tested the CI yet.

Fbada006 commented 4 months ago

Hey @CalebKL , set the indentation to 4 then test the CI.

CalebKL commented 4 months ago

@Fbada006 @emmanuelmuturia I have done a couple of changes on this PR,

  1. Revert the indentation to 4 spaces instead of two
  2. Tested the CI with spotlessApply and removed Lint check on the CI since spotlessApply will fail on ./gradlew build. Check this Failed CI test with unused import when running spotless and this Passing CI test when the unused import was fixed with ./gradlew spotlessApply
  3. Revert back the MoreVert overflow menu on the Controller and show the ModalBottomSheet when clicked.
  4. Updated the material icon depencency on the artmaker build gradle to use libs.version.toml