search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Remove test controller #32

Closed Fbada006 closed 4 months ago

Fbada006 commented 4 months ago

closes #26

This removes the test controller and we now use the viewmodel, which also persists the state.

Fbada006 commented 4 months ago

Hey @emmanuelmuturia . You need to review more PRs, if you wish to improve and know what is happening in the project. Make a point of checking your emails and see if you have a review requested of you.

Fbada006 commented 4 months ago

@Fbada006 Will we have more events apart from DrawEvent that are separate from the main Actions?

Most likely no. Why?

emmanuelmuturia commented 4 months ago

I wanted to know why we have an extra set of Actions that are separate from ArtMakerAction...

Fbada006 commented 4 months ago

I wanted to know why we have an extra set of Actions that are separate from ArtMakerAction...

Strictly speaking, these are events, not actions. They are events triggered during drawing. So they are not related to user actions, hence the distinction.