search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Improve export process and add programmatic export of drawn image #46

Closed Fbada006 closed 3 months ago

Fbada006 commented 3 months ago

closes #39

This PR makes a number of changes:

  1. No more overflow for more options
  2. Adds two FABS for sharing and exporting programmatically
  3. Adds a slot for exporting the image
Fbada006 commented 3 months ago

I am a bit indifferent with the FABs. This is fine for now but what if we add more Icons. This is no blocker but maybe we need to think more about this. @emmanuelmuturia WDYT?

I think Emmanuel is busy. In any case, we can worry about this later

emmanuelmuturia commented 3 months ago

@CalebKL and @Fbada006 Is it okay if I create one issue for all the things that we have deferred including the FAB?

CalebKL commented 3 months ago

@

I am a bit indifferent with the FABs. This is fine for now but what if we add more Icons. This is no blocker but maybe we need to think more about this. @emmanuelmuturia WDYT?

I think Emmanuel is busy. In any case, we can worry about this later

This is fine. I think this is good to go. Just check why the CI is failing and its good to merge