search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
34 stars 3 forks source link

Erasing Functionality (Feature) #76

Closed emmanuelmuturia closed 3 weeks ago

emmanuelmuturia commented 3 weeks ago
emmanuelmuturia commented 3 weeks ago

@Fbada006 This is noted. I have already merged the task branch to this feature branch...

CalebKL commented 3 weeks ago

@emmanuelmuturia one more thing, please mark this PR as a draft PR because its incomplete, as soon as you complete working on the changes, you can make it open and request a review.

Fbada006 commented 3 weeks ago

@Fbada006 This is noted. I have already merged the task branch to this feature branch...

Yes, but you are still trying to merge incomplete changes to master. That should not be done. The flow goes like this, create a feature branch from main, then publish the feature branch. From the feature branch, create a branch for a small task, then open a PR to merge back to the feature branch. This continues until you finish the feature branch, then open a pr from the feature to main. As it is, these changes cannot make it back to main because the feature is not even half complete.

emmanuelmuturia commented 3 weeks ago

@CalebKL and @Fbada006 I have converted the branch to a draft branch. Will that suffice or will I have to redo the entire process of creating the feature branch and its subsequent task branches?