FePhyFoFum / phyx

phylogenetics tools for linux (and other mostly posix compliant) computers
blackrim.org
GNU General Public License v3.0
111 stars 17 forks source link

pxtgen not found in current repo #128

Closed michael-branstetter closed 4 years ago

michael-branstetter commented 4 years ago

The manual says this function should be available now, but I can't find it after updating. Is this still in development?

josephwb commented 4 years ago

Try:

make clean
git pull
autoreconf -fi
./configure
make

and sudo make install if you want to install it.

Let us know if this works.

michael-branstetter commented 4 years ago

That did not work. When I entered "git pull", it returned "Already up to date."

Michael


Michael Branstetter, PhD USDA-ARS Pollinating Insects Research Unit Utah State University 5310 Old Main Hill Logan, UT 84322-5310 (435) 797-2588

On Thu, Feb 20, 2020 at 3:46 PM Joseph W. Brown notifications@github.com wrote:

Try:

make clean git pull autoreconf -fi ./configure make

and sudo make install if you want to install it.

Let us know if this works.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FePhyFoFum/phyx/issues/128?email_source=notifications&email_token=AB63K76EAAPKCBI5FS4UHHDRD4B2VA5CNFSM4KYWGS72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMQWDTA#issuecomment-589390284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB63K732O3NDNJBCBIUWM5TRD4B2VANCNFSM4KYWGS7Q .

josephwb commented 4 years ago

Ah ok. You have all the files, you just need to generate the Makefile.

Try the remaining commands above. You can even do make pxtgen to just make that one program.

michael-branstetter commented 4 years ago

I did go through all of the commands after git pull and pxtgen still did not compile. Typing "make pxtgen" separately did work, however, so problem solved.

Thanks, Michael


Michael Branstetter, PhD USDA-ARS Pollinating Insects Research Unit Utah State University 5310 Old Main Hill Logan, UT 84322-5310 (435) 797-2588

On Thu, Feb 20, 2020 at 3:59 PM Joseph W. Brown notifications@github.com wrote:

Ah ok. You have all the files, you just need to generate the Makefile.

Try the remaining commands above. You can even do make pxtgen to just make that one program.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FePhyFoFum/phyx/issues/128?email_source=notifications&email_token=AB63K74TKMHTMB645WXCQYLRD4DMBA5CNFSM4KYWGS72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMQXQRI#issuecomment-589396037, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB63K76VELTCWOWESNDA7DDRD4DMBANCNFSM4KYWGS7Q .

josephwb commented 4 years ago

Hmm. Try:

make distclean
autoreconf -fi
./configure
make -j
josephwb commented 4 years ago

Hrm I cannot recreate this. I cloned a very old version of the repo, built, pulled, and rebuild again and everything is as it should be. I am baffled. Obviously you have the code and the compile command in your Makefile, but it feels like pxtgen is not part of the default build.

Can you please report the results of (from the src dir):

grep -n pxtgen Makefile

My results are:

340:PROGS := pxmrca pxmrcacut pxmrcaname pxconsq pxbdsim pxlstr pxlssq pxupgma pxclsq pxcltr pxs2fa pxs2phy pxs2nex pxfqfilt pxrevcomp pxnw pxsw pxboot pxcat pxsstat pxrecode pxbp pxt2new pxt2nex pxrr pxmono pxaa2cdn pxtlate pxrms pxrmt pxtrt pxrmk pxnj pxlog pxvcf2fa pxrlt pxrls pxtscale pxstrec pxseqgen pxssort pxcontrates pxtcol pxtcomb pxtgen pxssort pxcolt pxcomp $(NLOPT_PROGRAMS)
584:pxtgen: $(CPP_OBJS) $(TGEN_OBJ)
585:    @echo 'building pxtgen'
586:    $(CXX) -o "pxtgen" $(OPT_FLAGS) $(TGEN_OBJ) $(CPP_OBJS)

That first line (PROGS) lists the default build, which contains pxtgen.

If you are missing the PROGS line above, does this find it:

grep -n pxtgen Makefile.in

If so, something went wrong with configure.

If you are missing that line in any of your results, it must be some old commit in between implementing the method and adding it to the default build.

josephwb commented 4 years ago

Since I cannot recreate this I'm going to close this for now. Please re-open if new information surfaces.