search

FeTS-AI / Algorithms

This repo contains the model architectures to be used in the OpenFL backend.
Other
7 stars 11 forks source link

Possible duplicated code #83

Closed sharkovsky closed 1 year ago

sharkovsky commented 1 year ago

Hi,

first of all thank you for the FeTS initiative!

I am working through your code and noticed there seems to be a spurious code duplication here (lines 219-223).

It shouldn't change any results because the second call to random_slices will just return an empty list, and the subsequent calls to crop will result in a no-op. However, if you're still maintaining the code, it would be nice to take a quick look!

In any case, thank you for making your code open-source and doing a great jov towards reproducible science!

sarthakpati commented 1 year ago

Thanks for the report, @sharkovsky!

As you correctly identified, there is indeed duplication, and (as you also mentioned) it wouldn't affect the output. Also, the FeTS code is purely in maintenance mode ATM since we have moved all the development from FeTS into different projects:

All 3 are designed to work seamlessly with each other, and we will be showcasing the entire ecosystem in multiple conferences in the future [ref], as well as in the upcoming post-operative glioma study as part of our collaboration with RANO, and you can find more details about that study here.