Graphql set up - Githubissues

Feather-Flock / birds-api

0 stars 3 forks source link

Graphql set up #5

Closed ClayAsh closed 2 years ago

ClayAsh commented 2 years ago

What this PR Covers

This PR adds Graphql, creates mutation and type files, and includes a test for create user.

Type of Content in PR

[X] Spec Files
[ ] Controllers / Facades / Poros
[ ] Service Requests
[X] Route Change
[X] Gemfile Update
[ ] Other:

Is this a fully completed API Endpoint?

[ ] yes - API Endpoint:
[X] no

Simplecov 100% Coverage

[ ] yes
[X] no
If no, what files are not being covered?
There are a couple Graphql methods that aren't fully tested yet.
Tested on Localhost/Postman
[ ] yes
[X] no
If no, why was it not?

Additional Comments

enalihai commented 2 years ago

This looks great. I think I understand what its doing, I was looking a lot at mutations in my research.

One thing is, I would add /.DS_Store to the .gitignore file and remove the DS_Store from this PR before it gets merged. It takes a snapshot of your own personal files that can mess with other contributors when they pull it down. I am going to select that I have reviewed this PR, and once the ds_store is removed / added to .gitignore, i believe it should be good to go.

great work!

deannahburke commented 2 years ago

Merging, not sure about DS store file but going to take a look with Clay after PR is merged and make sure it's ignored.