List gometalinter checks which can run continuously

[jaffee]

Description

As described in #1287, we'd like to run gometalinter in CI. We need to identify which checks we can run automatically that won't generate false positives. We'll list these checks here and create breakout tickets for each of them to (a) fix all the issues identified by the check and (b) add the check to CI.

Success criteria (What criteria will consider this ticket closeable?)

We'll close this ticket at the same time as #1287 once all checks are identified and in CI.

[codysoyland]

The following linters have errors (annotated with number of errors):

• dupl: 619 duplicated code
• golint: 195 mostly uncommented exported names

Probably won't fix:

• errcheck: 99
• gas: 34
• gochecknoglobals: 48
• goconst: 19
• gocyclo: 178
• lll: 1856
• vetshadow: 46

Completed:

• deadcode: 16
• gochecknoinits: 20
• gofmt: 8
• goimports: 1
• gosimple: 0
• ineffassign: 8
• interfacer: 3
• maligned: 7
• megacheck: 76
• misspell: 4
• nakedret: 14
• staticcheck: 0
• unconvert: 60
• unparam: 52
• unused: 24
• vet: 7
• gotype
• gotypex

Redundant: megacheck combines the following linters into one:

• gosimple
• unused
• staticcheck

Redundant: unused is superset of:

• varcheck: 4
• structcheck: 3

This is not applicable:

• safesql

[codysoyland]

There are still a few remaining metalinter tickets, but most of the linters are now in CI and enabled. See #1504 and tickets with label metalinter.