FeatureBaseDB / featurebase

A crazy fast analytical database, built on bitmaps. Perfect for ML applications. Learn more at: http://docs.featurebase.com/. Start a Docker instance: https://hub.docker.com/r/featurebasedb/featurebase
https://www.featurebase.com
Apache License 2.0
2.53k stars 233 forks source link

handle count(*) in `having` correctly #2274

Closed seebs closed 1 year ago

seebs commented 1 year ago

After tracking through a whole bunch of unrelated code and coming up with a 40-line patch that mostly fixed this, I realized that the fact that it worked for count(field) meant something was making it work, added countStarPlanExpression to that case, and magically everything got better.

Writing one line of code: 30 seconds Figuring out which one line of code to write: two days

seebs commented 1 year ago

@tgruben, tagged you on review because Pat looked at the original second commit, figured out it was wrong, and fixed it, so now the second commit in particular needs someone else to look at it and verify that this makes sense.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication