search

FeatureBaseDB / featurebase

A crazy fast analytical database, built on bitmaps. Perfect for ML applications. Learn more at: http://docs.featurebase.com/. Start a Docker instance: https://hub.docker.com/r/featurebasedb/featurebase
https://www.featurebase.com
Apache License 2.0
2.53k stars 233 forks source link

support null/not-null on non-BSI fields #2311

Closed seebs closed 1 year ago

seebs commented 1 year ago

This PR adds support for null/not-null on non-BSI fields, including testing for that and making that work in SQL.

seebs commented 1 year ago

Hi! I've tagged a couple of people for review on this. Would really like to get feedback on this by COB friday, because this is a large patch and will be vulnerable to bit-rot and conflicts from other changes coming in. Have a call scheduled this afternoon for an overview of how this works.

seebs commented 1 year ago

Updated to address some of these issues. Centralized the logic for "are we actually tracking existence", which I'm not super pleased with name-wise but it's at least clear. I haven't gone over all the stuff in the featurebase package with that, because it's less relevant there -- most of the code there making TrackExistence choices is doing it in already-constrained contexts.

seebs commented 1 year ago

Added a quick fix for a thing Bruce reported which turned out not to be related but to be in the code I was already looking at.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication