search

FeatureBaseDB / featurebase

A crazy fast analytical database, built on bitmaps. Perfect for ML applications. Learn more at: http://docs.featurebase.com/. Start a Docker instance: https://hub.docker.com/r/featurebasedb/featurebase
https://www.featurebase.com
Apache License 2.0
2.53k stars 230 forks source link

make IDK check featurebase version #2350

Closed seebs closed 1 year ago

seebs commented 1 year ago

After a weird CI failure that suddenly went away, I have theorized that we're getting cached versions of the featurebase docker image in CI when we don't intend to, and thus, running IDK tests against the wrong version of featurebase. This checks for that problem.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

seebs commented 1 year ago

So go tests race failed in TestCLIIntegration/Stubbed_Framework/table, saying "race detected during execution of test", but it didn't actually dump the usual RACE DETECTED message showing what was being written or read. I don't know why, but I'm willing to try rerunning it and hope it goes away since it isn't in any of the affected code, but I'm creating a ticket for it.

seebs commented 1 year ago

nevermind the actual output is indeed there. still ignoring it for this PR but making a ticket for it.