search

FeatureBaseDB / featurebase

A crazy fast analytical database, built on bitmaps. Perfect for ML applications. Learn more at: http://docs.featurebase.com/. Start a Docker instance: https://hub.docker.com/r/featurebasedb/featurebase
https://www.featurebase.com
Apache License 2.0
2.53k stars 230 forks source link

uncomment old LIMIT tests, make them pass #2369

Closed seebs closed 1 year ago

seebs commented 1 year ago

We forward-ported a handful of tests from the previous parser which relied on LIMIT clauses, but then we didn't support that. Now that we do, we uncomment most of these tests, and actually give them the correct data structures to compare with.

We leave two tests commented out. One was using limit 10, 5 to express a limit plus offset, and the other is using not fld = 1 as a WHERE clause, but we don't support unary-not to negate other expressions.

In the process, we discover that converting a SELECT with a LIMIT clause back to a string has a missing space, and fix that.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
38.0% 38.0% Duplication