FeatureBaseDB / featurebase

A crazy fast analytical database, built on bitmaps. Perfect for ML applications. Learn more at: http://docs.featurebase.com/. Start a Docker instance: https://hub.docker.com/r/featurebasedb/featurebase
https://www.featurebase.com
Apache License 2.0
2.53k stars 230 forks source link

some AST and parser test coverage expansion #2378

Closed seebs closed 1 year ago

seebs commented 1 year ago

Now that we support function bodies, we add a test case or two for them, which reveal that we're not round-tripping, so we tweak things slightly to make that work. There's an open issue there with semicolon semantics that we should revisit once we allow more than one kind of trivial expression in function bodies.

Trying to figure out why the second case in time parsing never got evaluated, I discovered that it has no reason to exist. Took this as an excuse to standardize on a single time-parser that lives in one place and is used by everything else, which makes the code a bit shorter in most cases, and lets us be more confident that the semantics are always the same. This looks intrusive but it's actually pretty trivial.

Improves test coverage in ast.go and walk.go slightly, and might actually help slightly with some other files by removing lines of code that were actually unreachable but weren't obviously-unreachable until you spend ten minutes staring closely at the docs for the time package.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.1% 19.1% Duplication

seebs commented 1 year ago

this got merged in a different branch.