search

FeatureIDE / FeatureIDE

An extensible framework for feature-oriented software development
https://featureide.github.io/
GNU Lesser General Public License v3.0
129 stars 97 forks source link

Undo Source Change in the feature model editor causes errors #1230

Open johannesherschel opened 3 years ago

johannesherschel commented 3 years ago

Undoing changes made in the Source tab of the feature model editor can cause errors.

Example model: image

  1. Delete "Base".
  2. Switch to the Source tab of the editor and make a change that does not affect the model, e.g. add a space. Then switch back to the Feature Diagram tab.
  3. Undo Source Change. The model looks like this now: image
  4. Undo Delete. This literally deletes the legend: image

To make it worse, subsequent actions cause more problems:

  1. In the context menu of the diagram, the legend is still marked as shown. Disabling it leads to this diagram: image
  2. Enabling it again completely freezes Eclipse. After about a minute, we run out of memory: image
rahelsundermann commented 3 years ago

I can imagine that this is related to https://github.com/FeatureIDE/FeatureIDE/issues/1160 . Undoing the action (e.g., adding a space) in the source tab is not possible until switching to the feature diagram tab.

skrieter commented 1 year ago

Maybe we should think about revising the entire fm editor for graphical and textual editing.