search

FedML-AI / FedML

FEDML - The unified and scalable ML library for large-scale distributed training, model serving, and federated learning. FEDML Launch, a cross-cloud scheduler, further enables running any AI jobs on any GPU cloud or on-premise cluster. Built on this library, TensorOpera AI (https://TensorOpera.ai) is your generative AI platform at scale.
https://TensorOpera.ai
Apache License 2.0
4.19k stars 786 forks source link

GRPC fix #2225

Closed fedml-dimitris closed 2 months ago

fedml-dimitris commented 2 months ago

Fixing grpc compatibility with the fedml.ai platform and simplifying the user-end requirements to define the grpc server ip and port. The values defined in the grpc config file will override the default ip and port values.

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 17 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517948) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/master_job_runner.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-a8338ef9e15678f7bd58ef52b87e9cb9847bb06fbebb2e61e3023a96f6c3aa99R47) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517949) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/comm_utils/constants.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-2f6ff00e3c779c218ecf020339bd7c6d896f15cb420ac0cbdbb513f9d78afb94R115) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517951) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/device_client_runner.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-7b5edf8f66c2bff2685a3f81148f213ee792212d1f2c7742a6d81d57bc3ead65L120) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517952) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/worker_protocol_manager.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-5093bca8dc5376aa1ff58fe744ac314fa533677d837c4de1cd52473f974e2dd8R35) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517953) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/model_device_client.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-1d84cb3e795f3e049ae14beca1e1361d5263a6a0317b7cee2625ce96a3952f1aL32) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517954) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/scheduler_core/compute_cache_manager.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-6b9f65b2e8a898424de6b275c87683b837918f895444f910bbc41c80376a658aL28) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517955) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/api/modules/device.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-7800d9f535b0ee655bc0adfcafaf53189bc660a3b3d93d2b8e6c4994b06aa1e4L30) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517956) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/worker_job_runner.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-585911cda4f68c25d598f621e30e2db39424315212dbace54200e7a72db7b8e5R41) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517957) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/master_job_runner.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-a8338ef9e15678f7bd58ef52b87e9cb9847bb06fbebb2e61e3023a96f6c3aa99R30) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517958) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/model_device_server.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-47cb763a0c441700638c3562f0b36032a9791f67be848a02a6623a9c44202758L32) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517959) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/device_model_inference.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-49942b6da713f85ea00e82c9a13c5db43e5f87f954d7c6da6b13e4695e6b05ebL48) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517960) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/job_runner_msg_sender.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-a4aaeda44b989ddef327199d6e8bacc0473377034722ef0b6680be228390ac39R16) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517961) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/master_job_runner.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-a8338ef9e15678f7bd58ef52b87e9cb9847bb06fbebb2e61e3023a96f6c3aa99R469) | | [5451874](https://dashboard.gitguardian.com/workspace/227819/incidents/5451874?occurrence=165517963) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/master_protocol_manager.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-884df29360da5727180d5ed7ef03c95592f86f14d2c05501a412600390ef90e4R32) | | [5692101](https://dashboard.gitguardian.com/workspace/227819/incidents/5692101?occurrence=165517962) | Triggered | Generic High Entropy Secret | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-bfea1945708cf4ed38b33387f10484ada5c5454df9b186b06b870fadc369f218L754) | | [9453265](https://dashboard.gitguardian.com/workspace/227819/incidents/9453265?occurrence=165517950) | Triggered | Generic High Entropy Secret | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/api/api_test.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-815c6bfd32c6143a20c19d15d772a2374ef07be1174765dcdad5d737d54e75ddL9) | | [8762943](https://dashboard.gitguardian.com/workspace/227819/incidents/8762943?occurrence=165517964) | Triggered | Generic Password | 87ae30ad79452984d0dd3437c7f8406c5cd28d97 | python/fedml/computing/scheduler/scheduler_core/compute_cache_manager.py | [View secret](https://github.com/FedML-AI/FedML/commit/87ae30ad79452984d0dd3437c7f8406c5cd28d97#diff-6b9f65b2e8a898424de6b275c87683b837918f895444f910bbc41c80376a658aL47) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.