search

FedStoa / moa

A Mastodon, Twitter, and Instagram Cross-poster
https://moa.party
MIT License
356 stars 19 forks source link

Issue with multiple/threaded replies from Twitter ->Mastodon #83

Closed aziraphale closed 5 years ago

aziraphale commented 6 years ago

Hi again :)

The Android Twitter app seems to have been recently updated to allow you to post multiple messages in reply to someone else (i.e. when you click the "reply" button, there's now a "+" button in the reply activity to let you add more Tweets to the reply). This is great news for overly-verbose people like myself, but it seems to have tripped up Moa :(

For example, this three-Tweet reply of mine resulted in the second and third Tweets being posted to Mastodon as completely normal messages; the first reply was correctly ignored. (I've since deleted those erroneous messages from Masto to save confusion of people reading only the latter two-thirds of a reply!)

I appreciate that posting "replies to yourself" to Masto is the correct behaviour, which would be why this happened, but hopefully it won't be too big of a deal to check if the first message in a string of self-replies is a reply to someone else (both from a technical perspective, and from hoping that doing so won't adversely affect something else)?

(I used to operate a PHP-IRC bot for which I wrote a module to syndicate Tweets into an IRC channel, and I used to have to deal with problems like this all the time. I'm rather glad I don't have to anymore!)

Thanks again for your work on this, and hosting it publicly! :)

foozmeat commented 6 years ago

The problem is that Moa can't track replies to messages it doesn't know about. Your 3 replies are replies to a twitter message and not self-replies. There's no way for Moa to know that these replies should be changed to be self-replies. Unfortunately I can't think of a solution for this problem.

foozmeat commented 5 years ago

I think this is going to be fixed soon. Moa will no longer post replies to messages that didn't get cross-posted and that will stop this chain of events. If it still happens after I post the update please reopen this issue.