i think is error - Githubissues

FedUni / caliko

The Caliko library is an implementation of the FABRIK inverse kinematics algorithm in Java.

MIT License

160 stars 35 forks source link

i think is error #14

Closed lo-th closed 6 years ago

lo-th commented 6 years ago

hello in FabrikChain3D.java on solveIK Backward pass

end GLOBAL_HINGE and LOCAL_HINGE have Utils.approximatelyEquals(cwConstraintDegs , FabrikJoint3D.MAX_CONSTRAINT_ANGLE_DEGS, 0.01f) but should be Utils.approximatelyEquals(cwConstraintDegs , -FabrikJoint3D.MAX_CONSTRAINT_ANGLE_DEGS, 0.01f)

alansley commented 6 years ago

Yup - you're absolutely correct, good eyes! =D

I've added those missing minus signs and pushed the changes.

Cheers!