FedeDP / Clightd

A linux bus interface that lets you change screen brightness, compute captured webcam frames brightness and change screen temperature.
GNU General Public License v3.0
83 stars 10 forks source link

make problem #33

Closed loveCrypto closed 4 years ago

loveCrypto commented 4 years ago

First thank you for this great piece of software. After a OS Update, i updated clightd and get a problem with make. Maybe you know what to do.

illu@illu ~/src/Clightd/build (git)-[master] % make
[  6%] Building C object CMakeFiles/clightd.dir/src/modules/backlight.c.o
/home/illu/src/Clightd/src/modules/backlight.c: In function 'init':
/home/illu/src/Clightd/src/modules/backlight.c:168:23: error: too many arguments to function 'map_new'
  168 |     running_clients = map_new(false, dtor_client);
      |                       ^~~~~~~
In file included from /home/illu/src/Clightd/src/modules/backlight.c:2:
/usr/local/include/module/map.h:26:17: note: declared here
   26 | _public_ map_t *map_new(void);
      |                 ^~~~~~~
/home/illu/src/Clightd/src/modules/backlight.c: In function 'add_backlight_sn':
/home/illu/src/Clightd/src/modules/backlight.c:260:9: error: too few arguments to function 'map_put'
  260 |         map_put(running_clients, sc->d.sn, sc);
      |         ^~~~~~~
In file included from /home/illu/src/Clightd/src/modules/backlight.c:2:
/usr/local/include/module/map.h:28:23: note: declared here
   28 | _public_ map_ret_code map_put(map_t *m, const char *key, void *value, const bool dupkey);
      |                       ^~~~~~~
/home/illu/src/Clightd/src/modules/backlight.c: In function 'method_setallbrightness':
/home/illu/src/Clightd/src/modules/backlight.c:303:9: warning: implicit declaration of function 'map_clear' [-Wimplicit-function-declaration]
  303 |         map_clear(running_clients);
      |         ^~~~~~~~~
make[2]: *** [CMakeFiles/clightd.dir/build.make:76: CMakeFiles/clightd.dir/src/modules/backlight.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/clightd.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Thx!

FedeDP commented 4 years ago

Hi! Clightd-git and clight-git require libmodule 5.0.0 that was released a couple of months ago. In my mind, it wouldn't have taken so long to release new clight and clightd. Unfortunately real life is always ready to kick in, you know :)

FedeDP commented 4 years ago

Finally i took the time to release clight and clightd 4.0. The issue is now fixed.