FedeDP / Clightd

A linux bus interface that lets you change screen brightness, compute captured webcam frames brightness and change screen temperature.
GNU General Public License v3.0
82 stars 10 forks source link

Missing build deps in wiki for Fedora #78

Closed NICHOLAS85 closed 2 years ago

NICHOLAS85 commented 3 years ago

I found the following two were also needed to build Clightd in Fedora 34: polkit-devel dbus-devel

FedeDP commented 3 years ago

Hi! Thanks for letting me know :) I will update wiki asap!

FedeDP commented 3 years ago

On a second thought, Clightd shouldn't depend upon those libraries: it uses sd-bus from systemd for dbus API, and polkit api is never called (it is only invoked through dbus). Are you sure Clightd isn't building without those?

NICHOLAS85 commented 2 years ago

Yea I get the following two build errors until I installed those dependencies:

-- Checking for module 'polkit-gobject-1'
--   Package 'polkit-gobject-1', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:556 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:778 (_pkg_check_modules_internal)
CMakeLists.txt:28 (pkg_check_modules)
-- Checking for module 'dbus-1'
--   Package 'dbus-1', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:556 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:778 (_pkg_check_modules_internal)
CMakeLists.txt:29 (pkg_check_modules)

https://rpmfind.net/linux/rpm2html/search.php?query=pkgconfig(polkit-gobject-1) https://rpmfind.net/linux/rpm2html/search.php?query=pkgconfig(dbus-1)

FedeDP commented 2 years ago

You're right! I added them to the wiki page! Sorry, i could not remember...they are only used as build deps though!