search

FedeDP / ncursesFM

Ncurses File Manager for linux
GNU General Public License v3.0
85 stars 2 forks source link

Preview Images and Documents #6

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hi, as posted here on reddit. How about a image preview feature? Maybe a feature to preview documents (pdf, odt, html).

I think it would be nice to have a fast CLI filemanager to manage my images. Ranger also have this feature http://ranger.nongnu.org/.

FedeDP commented 8 years ago

I'll look into that! Thanks for posting the issue here!

FedeDP commented 8 years ago

I'm currently working on it, it is kinda working right now to be honest, but i still need to fix some issues. :) screenshot_20160508_130939

ghost commented 8 years ago

Nice, this was a fast response :+1: Is it working with transparent Terminal? Like the popular urxvt?

FedeDP commented 8 years ago

Mmmh as stated here (the following guide seems that has provided great help to vifm and ranger developers) it seems urxvt should not render images with transparency enabled: http://blog.z3bra.org/2014/01/images-in-terminal.html Btw i quickly tried and it seems to be working (well, 2 years passed since that blog post), BUT i do not use urxvt so i may have done some mistakes. You'll be able to try yourself as soon as remaining issues got squashed :)

FedeDP commented 8 years ago

In "image_previewer" branch you can find a working version of the image previewer plus some other fixes and improvements all around (eg: per-user settings, reworked helper screen that now updates its content based on active tab mode, more evident active tab, in conf file user can now customize latest line ("sysinfo" line) layout...and fixes all around the code)...yes i should have called it "develop" branch...

Btw i tested image preview with standard xterm and urxvt (as found in arch repos), and it's working perfectly fine. But your configuration may have some issues. Eg: in konsole i've still got an issue...so it depends a lot on how terminals manage screen. Understandable, as terminal were not meant to display images.

So, let me know if you've got issues, thanks :) I'll try to fix them before merging into master! Attach your terminal config too, so i can properly test. And please, be aware of the limitations abovementioned!

Have a nice weekend, and thanks for your time! :)

FedeDP commented 8 years ago

PS, i forgot that: use 'j' to enable preview!

FedeDP commented 8 years ago

I'll close this as i removed image previewing support, and won't implement any kind of preview. I think it is useless to have features that work inconsistently between terminal applications/systems. In my opinion it is better not to have a feature, instead of having a feature that works on X systems, somewhat works on Y systems and doesn't work on Z systems.

Moreover, image preview (and previews in general) are somewhat too fancy for a terminal ncurses based fm.