search

FederatedAI / KubeFATE

Manage federated learning workload using cloud native technologies.
Apache License 2.0
423 stars 221 forks source link

add more pulsar config for external pulsar #760

Closed stone-wlg closed 2 years ago

stone-wlg commented 2 years ago

add more pulsar config for external pulsar

Description

We want to use external pulsar or pulsar cluster to improve performance

stone-wlg commented 2 years ago

Thanks for the contribution.

You are adding them at the wrong position, currently it's under the configuration block of "python"

For pulsar config, your need to check how these two configurations were added and follow the same way:

https://github.com/FederatedAI/KubeFATE/blob/9e5c55a24d245bccfd91c418a9050db46384b7c1/helm-charts/FATE/values-template-example.yaml#L366

oh, maybe the title is not clearly enough. it is not pulsar itself config, it is about pulsar client config that is the python, so it should be under the block of the python.