FederatedAI / KubeFATE

Manage federated learning workload using cloud native technologies.
Apache License 2.0
418 stars 222 forks source link

The persistence PV size of python can not set the desired size properly #859

Closed PenHsuanWang closed 1 year ago

PenHsuanWang commented 1 year ago

What deployment mode you are use? Kuberentes.

What KubeFATE and FATE version you are using? KubeFate version : v.1.4.5 Fate version : v1.10.0

MUST Please state the KubeFATE and FATE version you found the issue

KubeFate version: v1.4.5

What OS you are using for docker-compse or Kubernetes? Please also clear the version of OS.

Desktop (please complete the following information):

To Reproduce

Installing kubefate cluster following with the example example/party9999/cluster-spark-local-pulsar.yaml

What happen?

I am trying to add a persistent volume to the pod python-0 which runs fateflow with 100 Gi capacity. but the persistence size request is still inactivated via cluster.yaml setting.

Here is found the potential issue coming from the helm-charts https://github.com/FederatedAI/KubeFATE/blob/9bf1319dc9d2993c3c40642ee5a940146620a6ab/helm-charts/FATE/templates/core/python-spark.yaml#L241

The tag used storage: {{ .Values.modules.mysql.size }} to setting python-data PV.

Should we change the storage: {{ .Values.modules.~~mysql~~.size }} to storage: {{ .Values.modules.python.size }} for this issue?

Screenshots

here setting the cluster.yaml

But the PV size setting of python-0 is not activated.

work around test

to work around this, set the desired python-0 pv size on mysql setting mysql size can work around

Additional context

owlet42 commented 1 year ago

The PR has been merged and this issue will be closed.