Full text search on the opportunities Title and Description fields

FederationOfTech / Coalesce

An open source volunteer management platform from the Federation of Humanitarian Technologists

GNU Affero General Public License v3.0

13 stars 13 forks source link

Full text search on the opportunities Title and Description fields #63

Closed alifhughes closed 3 years ago

alifhughes commented 3 years ago

As mentioned in Issue #6 full text search would like to be added to the Opportunities model
This is so we can search and filter them based on 'fuzzy' search criteria from the front end
This uses SearchFilter
Notes: Interested to see if people think it is better to split out the tests, I realise I have some further setup logic in the test before actually testing the search functionality

stefanha commented 3 years ago

One docker-compose exec api ./manage.py test failure was found. Otherwise it looks good, the test case could be split up but since it's not too big and no other tests cases need to share the setup, the current code seems fine for now.

FAIL: coalesce.opportunities.test.test_views:TestOpportunitiesListTestCase.test_post_request_with_query_params_returns_subset
  vi +45 coalesce/opportunities/test/test_views.py  # test_post_request_with_query_params_returns_subset
    eq_(response.status_code, status.HTTP_201_CREATED)
AssertionError: 403 != 201

alifhughes commented 3 years ago

One docker-compose exec api ./manage.py test failure was found. Otherwise it looks good, the test case could be split up but since it's not too big and no other tests cases need to share the setup, the current code seems fine for now.
FAIL: coalesce.opportunities.test.test_views:TestOpportunitiesListTestCase.test_post_request_with_query_params_returns_subset
  vi +45 coalesce/opportunities/test/test_views.py  # test_post_request_with_query_params_returns_subset
    eq_(response.status_code, status.HTTP_201_CREATED)
AssertionError: 403 != 201

Failed test came after I had merged main's changes into my own and there was some new auth code, sorry about that 🤦 Fixed now