search

FedericoCinus / WoMG

WoMG: Word of Mouth Generator
3 stars 0 forks source link

Many fields are conflated in a dictionary with a lot of keys, causing performance degradation #10

Closed corradomonti closed 5 years ago

corradomonti commented 5 years ago

@FedericoCinus can you remind us which fields are those?

FedericoCinus commented 5 years ago

Here you were referring to the interest and influence dictionary. For now we have only one dictionary with: (node_index, str(interest)) : [topic-dim interests vector] (node_index, str(influence)) : [topic-dim influence vector]

corradomonti commented 5 years ago

Which should be clearly separated into two fields self.interests and self.influences, both (node -> vectors), either as dict {0 -> v0, 1 -> v2, ...} or as a list [v0, v1, ...].

corradomonti commented 5 years ago

Is the same happening in any other part of the library?

FedericoCinus commented 5 years ago

No

FedericoCinus commented 5 years ago

Interests vectors and influence vectors are now in two different class attributes. Commit be11d40f7566cd1dae16836fdf2453b898697446