search

FedericoCinus / WoMG

WoMG: Word of Mouth Generator
3 stars 0 forks source link

Progress bars #2

Closed corradomonti closed 5 years ago

corradomonti commented 5 years ago

If I understood correctly from example.ipynb, there is one progress bar per cascade, is that correct? If the user asks for >1000 cascade, they will see a sequence of 1000 different progress bars. Maybe it's worth it to have one progress bar, which is incremented step by step inside each cascade, but contains all cascades. tqdm should allow for this.

Also, inside notebooks (example.ipynb) one should import from tqdm import tqdm_notebook instead of from tqdm import tqdm. Maybe we can provide an option for that? 🤔 They would be much better to look at and more "exportable" than text-based bars, when used inside Jupyter.

FedericoCinus commented 5 years ago

There is one tdqm bar for each cascade. I think that tdqm is optimized in terminal executions to show only the necessary ones. For now the progress bars seems to work well only in terminal.

corradomonti commented 5 years ago

Cool! let's keep the issue open until methods have a progress_bar=tqdm to allow the usage of tqdm_notebook

FedericoCinus commented 5 years ago

New parameter progress_bar for using tqdm_notebook inside jupyter notebooks. NB: node2vec progress bars are still the same, I cannot change them.

c21df8e..4370724