search

FedericoCinus / WoMG

WoMG: Word of Mouth Generator
3 stars 0 forks source link

Wrapping node2vec parameters #21

Closed FedericoCinus closed 5 years ago

FedericoCinus commented 5 years ago

All the parameters relating to node2vec should be separated from the Topic-aware Network model described in tn.py

corradomonti commented 5 years ago

Btw this should be solved through solving #6 : separating node2interest from the rest should solve this issue too.

If this is correct, please close this issue and let's refer to #6 only.

FedericoCinus commented 5 years ago

If I correctly understand, even if we make a different module for node2interests we have to have all its parameter inside the network model class because node2interests is called there.

corradomonti commented 5 years ago

If the interest generation through a node2interest.py produces interests, then no parameters for it should be contained in any other other part of WoMG?

FedericoCinus commented 5 years ago

from node2interests import node2interests

class network_model(): ... def network_model_setup(): interests_matrix = node2interests(graph, p, q, ...)

FedericoCinus commented 5 years ago

[DECISION] We decided to create a new module (called node2interest.py) for interests generation; now there are two possibilities for using it:

  1. we keep the interests generation inside the (concrete) network model class importing node2interest as a function-> wrapping function is needed
  2. we use node2interest.py as a separate software with a different run and then we read its output in the (concrete) network model class -> wrapping function is not needed

For these reasons I will close this issue. See DECISION made on the #6 issue.