search

FedericoStra / tletools

Library to work with two-line element set files
MIT License
24 stars 13 forks source link

poliastro API change #5

Closed wumpus closed 4 years ago

wumpus commented 4 years ago

from tletools import TLE is currently crashing trying to find poliastro.core.angles.M_to_nu

Staring more closely at the problem, seems that M_to_nu might have been lost in a refactor, I will ask the poliastro guy:

https://github.com/poliastro/poliastro/issues/937

astrojuanlu commented 4 years ago

Hi! I left a comment in poliastro explaining why I dropped these functions. If @FedericoStra you are still maintaining this package, perhaps you want to replace M_to_nu(M, ecc) by E_to_nu(M_to_E(M, ecc), ecc)? TLEs only contain elliptic orbits anyway, and the eccentricities are contained.

codinghipster commented 4 years ago

PR out for this, @FedericoStra any chance you can take a look at it?

FedericoStra commented 4 years ago

Sorry for the delay and thank to everybody for the interest. I'm reviewing the proposed solution and will update as soon as possible.

FedericoStra commented 4 years ago

This issue should be resolved now. I merged #7 and added the fix also to the class TLEu, which was missing.

wumpus commented 4 years ago

Thank you!