search

Fedict / commons-eid

Java library to interact with the Belgian eID card
GNU Lesser General Public License v3.0
12 stars 5 forks source link

Cannot close the CardAndTerminalManager while using the BeIDCards implementation #9

Closed florian-courault closed 5 years ago

florian-courault commented 5 years ago

Hello, I noticed a bug using the BeIDCards class: When its "close" method is called, nothing happens: It calls the "stop" method of its BeIDCardManager, which does nothing, because the class uses its own object "CardAndTerminalManager". So, this one is never closed. I proposed a pull request that fixes this bug, here.

Thank you for your attention and for your very useful software :) !

janvdbergh commented 5 years ago

Thanks for your pull request. I will look into it tomorrow.

janvdbergh commented 5 years ago

Hi. I have merged your pull request and am now trying to do a release to maven.eid.belgium.be. (There are currently some issues with this maven repository, but you can already checkout tag commons-eid-parent-1.0.2 and build it yourself.) Thanks again for your contribution.

florian-courault commented 5 years ago

Thanks for your responsiveness and help !

florian-courault commented 5 years ago

Hello again, I would like to use your maven repository directly, but I cannot access it. Do you have any information about this?

janvdbergh commented 5 years ago

Hi, Florian. Apparently the Maven repository does not exist anymore. We are looking into a different solution (e.g. hosting the artifacts on Maven Central). For now, the only solution is to build the code yourself.