search

Fedict / eid-mw

eID Middleware (main repository)
GNU Lesser General Public License v3.0
198 stars 79 forks source link

Fix automake warnings and compiler warnings #150

Closed bvanassche closed 3 years ago

bvanassche commented 3 years ago

This patch series fixes the compiler warnings while building eid-mw on my workstation (openSUSE Tumbleweed Linux).

bvanassche commented 3 years ago

I'm fine with the reformat, but the eject_card "test" needs to remain first. It's a workaround for the fact that the machine on which the automated test suite runs (with a robot to eject the card and/or the USB device) sometimes puts the card reader in an unrecoverable sleep, which then causes the full test suite to fail. By ejecting both the card and the reader, we ensure that the reader is definitely not in unrecoverable sleep, and the first test that needs the reader will just insert the card and/or the reader if necessary.

Perhaps add a comment to that effect if you want.

For the other tests, ordering is not significant.

The eject_card again occurs as the first test and a comment has been added that explains why it occurs first.

bvanassche commented 3 years ago

Apparently commit b24a058 accidentally removed the dialogs test, which I think was not the intent. I'd rather re-add it to the TESTS variable than to comment it out.

Thanks for the feedback. I have dropped the patch that comments out the directives for the dialog test.

I need help with reenabling that test since it doesn't build.

bvanassche commented 3 years ago

Please also drop libbsd from README.md then

Hmm ... what did I miss? This patch removes the following line from the README: [libbsd](https://libbsd.freedesktop.org/).

yoe commented 3 years ago

Apparently commit b24a058 accidentally removed the dialogs test, which I think was not the intent. I'd rather re-add it to the TESTS variable than to comment it out.

Thanks for the feedback. I have dropped the patch that comments out the directives for the dialog test.

I need help with reenabling that test since it doesn't build.

Okay, so it turns out it wasn't disabled by accident, it was waiting on build system changes that I meant to do but forgot. That's my job for today :)

Just leave it out of the TESTS variable for now, I'll add it when it builds.

yoe commented 3 years ago

Please also drop libbsd from README.md then

Hmm ... what did I miss? This patch removes the following line from the README: [libbsd](https://libbsd.freedesktop.org/).

Nothing, I did. My bad, sorry.