search

Fedict / eid-mw

eID Middleware (main repository)
GNU Lesser General Public License v3.0
202 stars 78 forks source link

#ifdef WIN32 is used for MSVC specific constructs #177

Closed erikjanss closed 2 years ago

erikjanss commented 2 years ago

in :

cardcomm/pkcs11/src/common/util.cpp line 66

'#ifdef WIN32 ' is used to handle a difference between the MSVC standard library and the GCC standard library.

this prevents the use of the GCC standard library on windows, and prevents compilation of the pkcs11 plugin with mingw

yoe commented 2 years ago

Yeah, we should probably use defines that are based on the compiler name, rather than the platform name, for library differences, although platform differences should obviously be kept in.

We don't really have time to work on that though, so if you have patches, and they're sensible, that's definitely welcome.

erikjanss commented 2 years ago

I'll create a PR for this ...

erikjanss commented 2 years ago

PR created, using this code a working pkcs11 plugin can be compiled with mingw (with manual compilation)

Frederikus commented 2 years ago

PR accepted. Thank you Erik