Fedict / eid-mw

eID Middleware (main repository)
GNU Lesser General Public License v3.0
198 stars 79 forks source link

compile failed #202

Closed linuxunderground closed 4 months ago

linuxunderground commented 5 months ago

(...) configure: WARNING: no configuration information is in plugins_tools/xpi (...) Making all in plugins_tools/xpi make[2]: Entering directory '/var/tmp/portage/app-crypt/eid-mw-9999/work/eid-mw-9999/plugins_tools/xpi' make[2]: No rule to make target 'all'. Stop. make[2]: Leaving directory '/var/tmp/portage/app-crypt/eid-mw-9999/work/eid-mw-9999/plugins_tools/xpi' make[1]: [Makefile:490: all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/app-crypt/eid-mw-9999/work/eid-mw-9999' make: *** [Makefile:418: all] Error 2 (...)

NB: ./configure --without-xpipackage does nothing.

yoe commented 5 months ago

I can't reproduce this. Also, we do still need the xpi source to be part of the distributed tarball, which this destroys. So we can't merge that.

Of course, if this does happen to you then we need to fix that. Just not like this :smiley:

Did you apply any other patches to any of the autotools files? If so, can you try to reproduce with a vanilla configuration, just to rule out that any of your changes is responsible? If not, can you perhaps make a config.log available somewhere, so we can debug?

linuxunderground commented 4 months ago

OK I understand. And I understand what happened : eautoreconf from Gentoo portage doesn't work the same way as vanilla autoreconf so the xpi's configure file is not generated. I keep my patch as is for Gentoo package. It's not really a problem. Moreover, from what I understand, theorically, pacakge, maintainers don't need to compile xpi since the xpi module installation is "user wide" and not "system wide". So it is the user who must install it and not the linux distro itself.

yoe commented 4 months ago

OK I understand. And I understand what happened : eautoreconf from Gentoo portage doesn't work the same way as vanilla autoreconf so the xpi's configure file is not generated. I keep my patch as is for Gentoo package. It's not really a problem.

OK, yeah, that makes sense then. Glad we sorted that out :smiley:

Moreover, from what I understand, theorically, pacakge, maintainers don't need to compile xpi since the xpi module installation is "user wide" and not "system wide". So it is the user who must install it and not the linux distro itself.

That's one option, yes. However, it's also possible to install a Firefox add-on system wide, which we do for the Debian- and RPM-based systems that we support, which we do with the pre-signed .xpi file that we ship in the packages; it is installed under /usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}. The downside of that method however is that it may result in the add-on being installed but not activated for some users. I'm not sure why that is the case.

Additionally, the Firefox add-on configures the PKCS#11 module for Firefox, but not for Google Chrome or any other browsers. For that, we ship the stuff under plugins_tools/chrome_pkcs11. It should be installed by the autotools build system in such a way that it is automatically run at login time by any XDG-compliant environment, but you might want to double-check that it is and that it works as expected.