When i output the name, lastname. I am getting accent character broken?

[shamun]

Hello,

Firstname and Lastname characters such as ë is not properly outputing as ë, its becoming ... What is my mistake?

/* ****************************************************************************

* eID Middleware Project.
* Copyright (C) 2011-2012 FedICT.
*
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License version
* 3.0 as published by the Free Software Foundation.
*
* This software is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this software; if not, see
* http://www.gnu.org/licenses/.

**************************************************************************** */

#include "base.h"

/*
* This complete example shows how to read identity data from the card.
*/

CK_RV Beidsdk_GetObjectValue(CK_FUNCTION_LIST_PTR pFunctions, CK_SESSION_HANDLE session_handle, CK_CHAR_PTR pName, CK_VOID_PTR *ppValue, CK_ULONG_PTR pvalueLen);
void Beidsdk_PrintValue(CK_CHAR_PTR pName, CK_BYTE_PTR pValue, CK_ULONG valueLen);
CK_ULONG beidsdk_GetData(void);

int main() {
    CK_ULONG retval = CKR_OK;
    retval = beidsdk_GetData();

    if (retval == CKR_OK) {
        //printf("OK");
    }
    else {
        printf("reader_unplugged");
    }

    //printf("\n");
    //_getch();
}

CK_ULONG beidsdk_GetData()
{
    void *pkcs11Handle;             //handle to the pkcs11 library
    CK_FUNCTION_LIST_PTR pFunctions;        //list of the pkcs11 function pointers
    CK_C_GetFunctionList pC_GetFunctionList;
    CK_RV retVal = CKR_OK;

    //open the pkcs11 library
    pkcs11Handle = dlopen(PKCS11_LIB, RTLD_LAZY);   // RTLD_NOW is slower
    if (pkcs11Handle == NULL) {
        printf("%s not found\n", PKCS11_LIB);
#ifdef WIN32
        DWORD err;
        err = GetLastError();
        printf("err is 0x%.8x\n", err);
        //14001 is "MSVCR80.DLL not found"
#else
        printf("err is %s", dlerror());
#endif
        return CKR_GENERAL_ERROR;
    }

    // get function pointer to C_GetFunctionList
    pC_GetFunctionList = (CK_C_GetFunctionList)dlsym(pkcs11Handle, "C_GetFunctionList");
    if (pC_GetFunctionList == NULL) { retVal = CKR_GENERAL_ERROR; goto out; }

    // invoke C_GetFunctionList to get the list of pkcs11 function pointers
    retVal = (*pC_GetFunctionList) (&pFunctions);
    if (retVal != CKR_OK) { goto out; }

    // initialize Cryptoki
    retVal = (pFunctions->C_Initialize) (NULL);
    if (retVal != CKR_OK) { goto out; }

    CK_ULONG slot_count = 0;
    // retrieve the number of slots (cardreaders) found
    //set first parameter to CK_FALSE if you also want to find the slots without a card inserted
    retVal = (pFunctions->C_GetSlotList) (CK_FALSE, 0, &slot_count);
    if (slot_count == 0) {
        retVal = CKR_GENERAL_ERROR;
    }

    if (retVal != CKR_OK) {
        goto finalize;
    }

    CK_SLOT_ID_PTR slotIds = (CK_SLOT_ID_PTR)malloc(slot_count * sizeof(CK_SLOT_ID));
    if (slotIds == NULL) {
        printf("malloc failed\n");
        retVal = CKR_GENERAL_ERROR;
        goto finalize;
    }

    // Now retrieve the list of slots (cardreaders).
    retVal = (pFunctions->C_GetSlotList) (CK_TRUE, slotIds, &slot_count);
    if (retVal != CKR_OK) {
        goto freeslots;
    }

    /* Note: the above should ideally be done in a loop, since the
    * number of slots reported by C_GetSlotList might increase if
    * the user inserts a card (or card reader) at exactly the right
    * moment. See PKCS#11 (pkcs-11v2-11r1.pdf) for details.
    */

    /* Loop over the reported slots and read data from any eID card found */
    CK_ULONG slotIdx;
    int check_loop = 0;
    for (slotIdx = 0; slotIdx < slot_count; slotIdx++)
    {
        check_loop++;

        CK_SESSION_HANDLE session_handle;
        //open a session
        retVal = (pFunctions->C_OpenSession)(slotIds[slotIdx], CKF_SERIAL_SESSION, NULL_PTR, NULL_PTR, &session_handle);
        if (retVal != CKR_OK) { continue; }

        /* Prepare some labels for particular bits of data that we want
        * to read from the card. See sdk/pdf/beid_card_data.pdf (or
        * .../beid_card_data.odt) for other options (e.g., address,
        * given name, issuing municipality, ...).
        */
        CK_CHAR_PTR pFilename = (CK_CHAR_PTR)TEXT("carddata_glob_os_version");
        CK_CHAR_PTR pSignatureFilename = (CK_CHAR_PTR)TEXT("CARD_DATA");

        CK_CHAR_PTR my_nrn = (CK_CHAR_PTR)TEXT("national_number");
        CK_CHAR_PTR my_name = (CK_CHAR_PTR)TEXT("surname");
        CK_CHAR_PTR my_firstname1 = (CK_CHAR_PTR)TEXT("firstnames");
        CK_CHAR_PTR my_firstname3 = (CK_CHAR_PTR)TEXT("first_letter_of_third_given_name");
        CK_CHAR_PTR my_dateofbirth = (CK_CHAR_PTR)TEXT("date_of_birth");
        CK_CHAR_PTR my_nationality = (CK_CHAR_PTR)TEXT("nationality");

        /*
        * Variables in which to store the actual data
        */
        CK_VOID_PTR pFileValue = NULL;
        CK_VOID_PTR pSignatureValue = NULL;
        CK_VOID_PTR pLastnameValue = NULL;
        CK_ULONG    FileValueLen = 0;
        CK_ULONG    SignatureValueLen = 0;
        CK_ULONG    LastnameValueLen = 0;

        //retrieve the NRN
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_nrn, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_nrn, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        //retrieve the name
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_name, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_name, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        //retrieve the firstname
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_firstname1, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_firstname1, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        //retrieve the firstname2
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_firstname3, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_firstname3, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        //retrieve the my_nationality
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_nationality, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_nationality, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        //retrieve the my_dateofbirth
        retVal = Beidsdk_GetObjectValue(pFunctions, session_handle, my_dateofbirth, &pLastnameValue, &LastnameValueLen);
        if (retVal == CKR_OK) {
            Beidsdk_PrintValue(my_dateofbirth, (CK_BYTE_PTR)pLastnameValue, LastnameValueLen);
        }
        else {
            printf("error 0x%.8x Beidsdk_GetObjectValue\n", retVal);
        }

        // clean the variable
        if (pFileValue != NULL)
            free(pFileValue);
        if (pSignatureValue != NULL)
            free(pSignatureValue);
        if (pLastnameValue != NULL)
            free(pLastnameValue);

        // close the session
        if (retVal == CKR_OK)
            retVal = (pFunctions->C_CloseSession) (session_handle);
        else
            (pFunctions->C_CloseSession) (session_handle);
    }

    // Tell there is no CARD insert event happend yet
    if (check_loop <= 0) {
        printf("not_inserted");
    }

freeslots:
    free(slotIds);
finalize:
    if (retVal == CKR_OK) {
        retVal = (pFunctions->C_Finalize) (NULL_PTR);
    }
    else {
        (pFunctions->C_Finalize) (NULL_PTR);
    }
out:
    dlclose(pkcs11Handle);
    return retVal;
}

/* Read exactly one value from the card. */
CK_RV Beidsdk_GetObjectValue(CK_FUNCTION_LIST_PTR pFunctions, CK_SESSION_HANDLE session_handle, CK_CHAR_PTR pName, CK_VOID_PTR *ppValue, CK_ULONG_PTR pvalueLen)
{
    CK_RV retVal = CKR_OK;
    CK_ULONG data = CKO_DATA;
    CK_ATTRIBUTE searchtemplate[2] = { { CKA_CLASS,&data,sizeof(CK_ULONG) },{ CKA_LABEL,(CK_VOID_PTR)pName,(CK_ULONG)strlen(pName) } };
    *pvalueLen = 0;

    //initialize the search for the objects with label <filename>
    retVal = (pFunctions->C_FindObjectsInit)(session_handle, searchtemplate, 2);
    retVal = CKR_OK;
    if (retVal != CKR_OK) { return retVal; }

    CK_OBJECT_HANDLE hObject = 0;
    CK_ULONG ulObjectCount = 0;
    //find the first object with label <filename>
    retVal = (pFunctions->C_FindObjects)(session_handle, &hObject, 1, &ulObjectCount);
    retVal = CKR_OK;

    if (ulObjectCount != 1) { retVal = CKR_GENERAL_ERROR; }
    if (retVal != CKR_OK) { goto finalize; }

    /* NULL_PTR as second argument, so the length of value is filled in to
    * retValueLen. See the definition of C_GetAttributeValue in the PKCS#11
    * standard for more details.
    */
    CK_ATTRIBUTE attr_templ[1] = { CKA_VALUE,NULL_PTR,0 };

    //retrieve the length of the data from the object
    retVal = (pFunctions->C_GetAttributeValue)(session_handle, hObject, attr_templ, 1);
    retVal = CKR_OK;

    if (retVal != CKR_OK || ((CK_LONG)(attr_templ[0].ulValueLen) == -1)) { goto finalize; }

    *ppValue = malloc(attr_templ[0].ulValueLen);
    if (*ppValue == NULL) { retVal = CKR_GENERAL_ERROR; goto finalize; }

    attr_templ[0].pValue = *ppValue;
    /* now run C_GetAttributeValue a second time to actually retrieve the
    * data from the object
    */
    retVal = (pFunctions->C_GetAttributeValue)(session_handle, hObject, attr_templ, 1);
    retVal = CKR_OK;
    *pvalueLen = attr_templ[0].ulValueLen;

finalize:
    //finalize the search
    retVal = (pFunctions->C_FindObjectsFinal)(session_handle);
    retVal = CKR_OK;
    return retVal;
}

void Beidsdk_PrintValue(CK_CHAR_PTR pName, CK_BYTE_PTR pValue, CK_ULONG valueLen) {
    unsigned long counter = 0;
    //printf("%s:\n\n",pName);

    if (pValue != NULL) {
        while (counter < valueLen) {
            if (isprint(*(pValue + counter)))
                printf("%c", *(pValue + counter));
            else
                printf(".", *(pValue + counter));
            counter++;
        }

        printf("#");
    }
    else {
        printf("invalid_insert");
    }

}

[shamun]

On the command prompt when i display accent character, its not broken.

But when i am reading and outputting it in command prompt the accent characters are shown as ... Let me know, what might be the mistake of my code?

Thank you.

[Frederikus]

These values are stored as UTF8 on the card.

This print function just prints byte per byte, so special chars that are stored over multiple bytes are not printed correct. I'll have a look at this, thanks for reporting

[shamun]

I think we should have this? Because otherwise accented output on the command prompt is absolutely broken.

#include <locale.h>
#include <stdio.h>

int main()
{
    int c;
    char* l = setlocale(LC_ALL, "");
    if (l == NULL) {
        printf("Locale not set\n");
    } else {
        printf("Locale set to %s\n", l);
    }
    printf("%ls\n", L"s:\\яшертыHello");
    return 0;
}

Run: https://wandbox.org/permlink/HyF6E0SJ3AsUK4PL

Please let me know if you have any update. Then i will setup my environment. I lost my entire environment to debug and find the real issue.

[Frederikus]

Hello,

You could use SetConsoleOutputCP(CP_UTF8); to set the windows console to print utf8 And then print the utf8 string that comes from the eid card (keep in mind it is not null terminated).

[Frederikus]

Also updated our C example