Fedihosting-Foundation / plemmy

A Python package for accessing the LemmyHttp API
Apache License 2.0
45 stars 15 forks source link

Bug fixes #18

Closed tjkessler closed 1 year ago

tjkessler commented 1 year ago

Per issue https://github.com/tjkessler/plemmy/issues/17, block_community did not work as of Plemmy version 0.3.4. I've tracked down the cause: it looks like the changes made in PR https://github.com/tjkessler/plemmy/pull/15 to the create_form utility function, i.e., turning boolean variables into strings, only really applies to get_person_mentions, as other functions such as block_community actually do require a boolean data type.

@mike-fmh: I had to revert some changes you made, but I think my solution of manually converting the boolean to a string fixes the get_person_mentions function. Not sure how many other similar functions are affected, feel free to make similar changes and make a PR if you run into any issues.

Very unfortunate that the API has some datatype mismatching, hopefully this will be fixed in the future.

Thanks to @AndrewFlan for pointing me in the right direction!

New version will be 0.3.5.