FedoraQt / MediaWriter

Fedora Media Writer - Write Fedora Images to Portable Media
GNU General Public License v2.0
743 stars 161 forks source link

Unpopulated information in Windows Programs uninstaller #183

Closed cyfrost closed 5 years ago

cyfrost commented 6 years ago

Hi,

I've installed Fedora Media Writer on a Windows 10 PC and noticed that the information related to version and icon of this app were left unpopulated. Please see the below image

untitled

Ideally we want the following information listed there:

What we have:

Name: Fedora Project - Fedora Media Writer - Tool to write Fedora images to flash drives Publisher: "Fedora Project" Version: "${MAJORVERSION}.${MINORVERSION}.${VERSIONBUILD}" Icon: <no icon listed>

What we want:

Name: Fedora Media Writer Publisher: Fedora Project Version: <current version of the program> Icon: <the icon of the program>

I can help with resolving this issue. I'm working on it, will raise a PR soon.

Thanks!

scootergrisen commented 6 years ago

Also would be nice if the size was there. The uninstaller seems to have a icon but it might be a generic one.

cyfrost commented 6 years ago

185 -- has the fixes for some of these issues. Would like to see it being approved and merged 👍