FedoraQt / MediaWriter

Fedora Media Writer - Write Fedora Images to Portable Media
GNU General Public License v2.0
708 stars 154 forks source link

Fix restore on Linux with latest UDisks/libblockdev #647

Closed vojtechtrefny closed 11 months ago

vojtechtrefny commented 11 months ago

The newly created partition cannot start on offset 0, previously UDisks was able to compensate for this, but there is a bug in the latest UDisks/libblockdev and this no longer works. But in general offset 0 for a new partition doesn't make sense. We can also use 0 for size to let UDisks calculate the maximal size instead of passing the underlying device size.

Fixes: #644


Note that we still plan to fix the UDisks/libblockdev bug, but I think it makes sense to change the values for offset and size here to make the code more future proof -- the 0 offset would never work, so you'd see the udisks warning anyway and having us calculate the max size could avoid some rounding/alignment issues in the future.