FedoraQt / MediaWriter

Fedora Media Writer - Write Fedora Images to Portable Media
GNU General Public License v2.0
708 stars 154 forks source link

Weblate repository browser URL for MediaWriter is broken #648

Closed rffontenelle closed 11 months ago

rffontenelle commented 11 months ago

Weblate has this awesome feature of linking a translation string source location to its source file in the source code repository. This makes it easier for the translator to go check the context with a single click in the Weblate web UI.

Currently, repository browser URL is broken for some strings in MediaWriter project. See the following alert in Fedora Weblate:

Broken repository browser URL

This component is set up incorrectly.

The repository browser URL points to non-existing locations:

This can happen if the path within the translation files contains references to a parent directory, or is absolute.

Appeared 2 years ago, last seen 10 hours ago

Notice in the resulting URL how "blob/main/../src" resulted in "blob/src" (missing the branch name).

The culprit is the source location having "../" in the beginning.

rffontenelle commented 11 months ago

Nevermind. I learned that Weblate can be configured to ignore to leading parent directory ...