search

FedoraQt / MediaWriter

Fedora Media Writer - Write Fedora Images to Portable Media
GNU General Public License v2.0
715 stars 154 forks source link

chore: specify UAC level to `requireAdministrator` in the manifest for Windows #700

Closed Cyanoxygen closed 6 months ago

Cyanoxygen commented 6 months ago

By specifying the UAC level in the manifest, the program will trigger a UAC prompt upon launch. Thus the helper will launch with administrator privileges:

image

We initially added the UAC level to the helper, however the way how helper.exe is launched does not allow the UAC prompt to pop up^1. Using alternative APIs can resolve this, but it would require a rewrite to apply the workaround, namely QProcess::startDetached(), which launches a new process that can not be managed by QProcess.

grulja commented 6 months ago

I guess we want to make a new release with this change, right?

MingcongBai commented 6 months ago

I guess we want to make a new release with this change, right?

I'd recommend that.