search

FedoraQt / QAdwaitaDecorations

Qt decoration plugin implementing Adwaita-like client-side decorations
GNU Lesser General Public License v2.1
72 stars 8 forks source link

[bug] build failure #18

Closed werdahias closed 1 year ago

werdahias commented 1 year ago

Hi, I'm in the process of packaging QAdwaitaDecorations for Debian. I did a qt5 build of the latest tarball but it fails halfway: 

[ 80%] Building CXX object src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations_autogen/mocs_compilation.cpp.o
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_THEME_SUPPORT_LIB -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -Dqadwaitadecorations_EXPORTS -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/include -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10/QtCore -isystem /usr/include/x86_64-linux-gnu/qt5/QtSvg -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10/QtThemeSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -fPIC -fPIC -MD -MT src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorationsplugin.cpp.o -MF CMakeFiles/qadwaitadecorations.dir/qadwaitadecorationsplugin.cpp.o.d -o CMakeFiles/qadwaitadecorations.dir/qadwaitadecorationsplugin.cpp.o -c /<<PKGBUILDDIR>>/src/qadwaitadecorationsplugin.cpp
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_THEME_SUPPORT_LIB -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -Dqadwaitadecorations_EXPORTS -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/include -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10/QtCore -isystem /usr/include/x86_64-linux-gnu/qt5/QtSvg -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10/QtThemeSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -fPIC -fPIC -MD -MT src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations_autogen/mocs_compilation.cpp.o -MF CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations_autogen/mocs_compilation.cpp.o.d -o CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations_autogen/mocs_compilation.cpp.o -c /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/mocs_compilation.cpp
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src && /usr/bin/c++ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_THEME_SUPPORT_LIB -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -Dqadwaitadecorations_EXPORTS -I/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/include -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.10/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore/5.15.10/QtCore -isystem /usr/include/x86_64-linux-gnu/qt5/QtSvg -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtWaylandClient -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport/5.15.10/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtXkbCommonSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10 -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport/5.15.10/QtThemeSupport -isystem /usr/include/x86_64-linux-gnu/qt5/QtThemeSupport -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++14 -fPIC -fPIC -MD -MT src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations.cpp.o -MF CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations.cpp.o.d -o CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations.cpp.o -c /<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp
In file included from /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/EWIEGA46WW/moc_qadwaitadecorations.cpp:10,
                 from /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/mocs_compilation.cpp:2:
/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/EWIEGA46WW/../../../../src/qadwaitadecorations.h:59:22: error: ‘MarginsType’ has not been declared
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                      ^~~~~~~~~~~
/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/EWIEGA46WW/../../../../src/qadwaitadecorations.h:59:14: error: ‘QMargins QAdwaitaDecorations::margins(int) const’ marked ‘override’, but does not override
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |              ^~~~~~~
/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/qadwaitadecorations_autogen/EWIEGA46WW/../../../../src/qadwaitadecorations.h:59:48: error: ‘Full’ was not declared in this scope
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                                                ^~~~
In file included from /<<PKGBUILDDIR>>/src/qadwaitadecorationsplugin.cpp:21:
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:22: error: ‘MarginsType’ has not been declared
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                      ^~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:14: error: ‘QMargins QAdwaitaDecorations::margins(int) const’ marked ‘override’, but does not override
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |              ^~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:48: error: ‘Full’ was not declared in this scope
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                                                ^~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorationsplugin.cpp: In member function ‘virtual QtWaylandClient::QWaylandAbstractDecoration* QAdwaitaDecorationsPlugin::create(const QString&, const QStringList&)’:
/<<PKGBUILDDIR>>/src/qadwaitadecorationsplugin.cpp:28:40: error: invalid new-expression of abstract class type ‘QAdwaitaDecorations’
   28 |         return new QAdwaitaDecorations();
      |                                        ^
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:35:7: note:   because the following virtual functions are pure within ‘QAdwaitaDecorations’:
   35 | class QAdwaitaDecorations : public QWaylandAbstractDecoration
      |       ^~~~~~~~~~~~~~~~~~~
In file included from /<<PKGBUILDDIR>>/src/qadwaitadecorations.h:26:
/usr/include/x86_64-linux-gnu/qt5/QtWaylandClient/5.15.10/QtWaylandClient/private/qwaylandabstractdecoration_p.h:94:22: note:     ‘virtual QMargins QtWaylandClient::QWaylandAbstractDecoration::margins() const’
   94 |     virtual QMargins margins() const = 0;
      |                      ^~~~~~~
In file included from /<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:20:
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:22: error: ‘MarginsType’ has not been declared
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                      ^~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:14: error: ‘QMargins QAdwaitaDecorations::margins(int) const’ marked ‘override’, but does not override
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |              ^~~~~~~
make[3]: *** [src/CMakeFiles/qadwaitadecorations.dir/build.make:93: src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorationsplugin.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/<<PKGBUILDDIR>>/src/qadwaitadecorations.h:59:48: error: ‘Full’ was not declared in this scope
   59 |     QMargins margins(MarginsType marginsType = Full) const override;
      |                                                ^~~~
make[3]: *** [src/CMakeFiles/qadwaitadecorations.dir/build.make:79: src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations_autogen/mocs_compilation.cpp.o] Error 1
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:262:10: error: ‘QMargins QAdwaitaDecorations::margins’ is not a static data member of ‘class QAdwaitaDecorations’
  262 | QMargins QAdwaitaDecorations::margins(MarginsType marginsType) const
      |          ^~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:262:39: error: ‘MarginsType’ was not declared in this scope
  262 | QMargins QAdwaitaDecorations::margins(MarginsType marginsType) const
      |                                       ^~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:262:64: error: expected ‘,’ or ‘;’ before ‘const’
  262 | QMargins QAdwaitaDecorations::margins(MarginsType marginsType) const
      |                                                                ^~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp: In member function ‘virtual void QAdwaitaDecorations::paint(QPaintDevice*)’:
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:298:30: error: ‘class QtWaylandClient::QWaylandWindow’ has no member named ‘toplevelWindowTilingStates’
  298 |             waylandWindow()->toplevelWindowTilingStates() != QWaylandWindow::WindowNoState;
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:298:78: error: ‘WindowNoState’ is not a member of ‘QtWaylandClient::QWaylandWindow’
  298 |             waylandWindow()->toplevelWindowTilingStates() != QWaylandWindow::WindowNoState;
      |                                                                              ^~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp: In member function ‘QRect QAdwaitaDecorations::windowContentGeometry() const’:
/<<PKGBUILDDIR>>/src/qadwaitadecorations.cpp:633:63: error: ‘ShadowsOnly’ was not declared in this scope
  633 |     return waylandWindow()->windowContentGeometry() + margins(ShadowsOnly);
      |                                                               ^~~~~~~~~~~
make[3]: *** [src/CMakeFiles/qadwaitadecorations.dir/build.make:107: src/CMakeFiles/qadwaitadecorations.dir/qadwaitadecorations.cpp.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:102: src/CMakeFiles/qadwaitadecorations.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:139: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j6 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2

any ideas to what I missed here ?

grulja commented 1 year ago

Should be fixed with https://github.com/FedoraQt/QAdwaitaDecorations/pull/19.