search

FedoraQt / QAdwaitaDecorations

Qt decoration plugin implementing Adwaita-like client-side decorations
GNU Lesser General Public License v2.1
72 stars 8 forks source link

Flatpak support #21

Closed sith-on-mars closed 12 months ago

sith-on-mars commented 1 year ago

Could we have Flatpak support for this as well? It would be massively beneficial since Flatpak is getting more and more popular nowadays.

grulja commented 1 year ago

Yes, definitely, I will try to bring this to Flathub as soon as possible. I need to do also some changes to QGnomePlatform and KDE runtime for that so it works out of the box.

grulja commented 1 year ago

Submitted here: https://github.com/flathub/flathub/pull/4556

sith-on-mars commented 1 year ago

Thanks a lot for supporting Flatpak. However, is there any instruction for enabling QAdwaitaDecorations for Flatpak apps? I tried flatpak override --env=QT_WAYLAND_DECORATION=adwaita, but it doesn't do anything.

grulja commented 1 year ago

This was only Qt6 build. I'm now doing Qt5 version.

CoolingTool commented 12 months ago

I have both the Qt6 and Qt5 versions installed, but none of my installed apps can find them

cooli@arch ~> flatpak list | rg QAdwaitaDecorations
QAdwaitaDecorations org.kde.WaylandDecoration.QAdwaitaDecorations       5.15-22.08  flathub system
QAdwaitaDecorations org.kde.WaylandDecoration.QAdwaitaDecorations       6.5 flathub system

cooli@arch ~> flatpak info org.kde.kolourpaint | rg Runtime ; flatpak run org.kde.kolourpaint
     Runtime: org.kde.Platform/x86_64/5.15-22.08
QSocketNotifier: Can only be used with threads started with QThread
Requested decoration  "adwaita"  not found, falling back to default

cooli@arch ~> flatpak info io.github.Arisotura.CoinKiller | rg Runtime ; flatpak run io.github.Arisotura.CoinKiller 
     Runtime: org.kde.Platform/x86_64/6.5
Requested decoration  "adwaita"  not found, falling back to default

Searching /var/lib/flatpak for libqadwaitadecorations.so brings up nothing image

Turns out both packages are only 4.1kb

cooli@arch ~> flatpak info org.kde.WaylandDecoration.QAdwaitaDecorations/x86_64/5.15-22.08 | rg  Installed
   Installed: 4.1 kB

cooli@arch ~> flatpak info org.kde.WaylandDecoration.QAdwaitaDecorations/x86_64/6.5 | rg  Installed
   Installed: 4.1 kB
grulja commented 12 months ago

Can you try build from here https://github.com/flathub/org.kde.WaylandDecoration.QAdwaitaDecorations/pull/1? It seem to fixed the issue for me.

CoolingTool commented 12 months ago

Yes it fixed the issue. Thank you

LSeelig commented 6 months ago

The latest update is yet to release for Flatpaks. It's not been very long (a week), but I don't know if the process requires review and is or isn't automatic after pushing an update.

grulja commented 6 months ago

The latest update is yet to release for Flatpaks. It's not been very long (a week), but I don't know if the process requires review and is or isn't automatic after pushing an update.

I did push updated to Flathub when I did the release. What Qt version is missing?

LSeelig commented 6 months ago

The latest update is yet to release for Flatpaks. It's not been very long (a week), but I don't know if the process requires review and is or isn't automatic after pushing an update.

I did push updated to Flathub when I did the release. What Qt version is missing?

None anymore. To my knowledge, it is resolved.