FedoraQt / QAdwaitaDecorations

Qt decoration plugin implementing Adwaita-like client-side decorations
GNU Lesser General Public License v2.1
77 stars 9 forks source link

Empty buttons after Arch system update #47

Open HubKing opened 12 months ago

HubKing commented 12 months ago

The theme was recently updated (and others), and now the buttons are empty. Top is Gnome Text Editor (GTK4), bottom is Strawberry (QT 6.6)

image

grulja commented 11 months ago

Can you run Strawberry with QAdwaitaDecorations debug enabled and attach the output here? You can do that by running export QT_LOGGING_RULES='qt.qpa.qadwaitadecorations=true'?

HubKing commented 11 months ago

I guess the log you are looking for is:

20:32:17.875 WARN  unknown                          Failed to find an svg icon for  "window-close-symbolic.svg" 
20:32:17.890 WARN  unknown                          Failed to find an svg icon for  "window-minimize-symbolic.svg" 
20:32:17.903 WARN  unknown                          Failed to find an svg icon for  "window-maximize-symbolic.svg" 
20:32:17.916 WARN  unknown                          Failed to find an svg icon for  "window-restore-symbolic.svg" 
20:32:17.920 WARN  unknown                          The cached device pixel ratio value was stale on window expose.  Please file a QTBUG which explains how to reproduce. 

I searched my HDD for those files, and they are in

/usr/share/icons/Adwaita/symbolic/ui/window-close-symbolic.svg
/usr/share/icons/Qogir/symbolic/actions/window-close-symbolic.svg
/usr/share/icons/Papirus/symbolic/actions/window-close-symbolic.svg
/usr/share/icons/Papirus-Dark/symbolic/actions/window-close-symbolic.svg

I am using Pipirus-Dark,

image

and the icons exist.

image

grulja commented 11 months ago

There should be also a debug message about what icon themes it search in. Can you include it?

HubKing commented 11 months ago

I ran with export .. & .. straw which seems a wrong way. I ran it again with &&, and now I get

20:52:21.026 DEBUG unknown                          Using Qt6 version 
20:52:21.095 DEBUG unknown                          Changing color scheme to  light 
20:52:21.108 WARN  unknown                          Failed to find an svg icon for  "window-close-symbolic.svg" 
20:52:21.122 WARN  unknown                          Failed to find an svg icon for  "window-minimize-symbolic.svg" 
20:52:21.135 WARN  unknown                          Failed to find an svg icon for  "window-maximize-symbolic.svg" 
20:52:21.148 WARN  unknown                          Failed to find an svg icon for  "window-restore-symbolic.svg" 
20:52:21.149 WARN  unknown                          The cached device pixel ratio value was stale on window expose.  Please file a QTBUG which explains how to reproduce. 
20:52:21.198 DEBUG unknown                          Changing color scheme to  dark 
20:52:21.201 DEBUG unknown                          Changing titlebar layout to  "appmenu:minimize,maximize,close" 
grulja commented 11 months ago

I somehow assumed you are using Fedora. Can you build latest version of QAdwaitaDecorations? Basically to get this change https://github.com/FedoraQt/QAdwaitaDecorations/commit/27d2899758f19abeb90fcb517aa2bfe8766576f4. You might need to build both Qt5 and Qt6 versions.

HubKing commented 11 months ago

You might need to build both Qt5 and Qt6 versions.

I don't know how to do it, and I just did what I had done in this https://github.com/FedoraQt/QAdwaitaDecorations/issues/15

It now has icons, but it seems it's not from the system's theme. So, it is using Adwaita icons, despite the fact that the system theme is Papyrus-Dark?

image

grulja commented 11 months ago

I tested it here with Papyrus and it worked. Since you build the new version, can you now run again with the debug?

HubKing commented 11 months ago

21:35:02.760 DEBUG unknown Using Qt6 version 21:35:02.832 DEBUG unknown Changing color scheme to light 21:35:02.833 DEBUG unknown Icon themes: QList("ePapirus-Dark", "hicolor", "Adwaita") 21:35:02.850 DEBUG unknown Using "window-close-symbolic.svg" from "Adwaita" theme 21:35:02.850 DEBUG unknown Icon themes: QList("ePapirus-Dark", "hicolor", "Adwaita") 21:35:02.866 DEBUG unknown Using "window-minimize-symbolic.svg" from "Adwaita" theme 21:35:02.866 DEBUG unknown Icon themes: QList("ePapirus-Dark", "hicolor", "Adwaita") 21:35:02.883 DEBUG unknown Using "window-maximize-symbolic.svg" from "Adwaita" theme 21:35:02.883 DEBUG unknown Icon themes: QList("ePapirus-Dark", "hicolor", "Adwaita") 21:35:02.902 DEBUG unknown Using "window-restore-symbolic.svg" from "Adwaita" theme 21:35:02.908 DEBUG unknown Changing color scheme to dark 21:35:02.908 DEBUG unknown Changing titlebar layout to "appmenu:minimize,maximize,close" 21:35:02.910 WARN unknown The cached device pixel ratio value was stale on window expose. Please file a QTBUG which explains how to reproduce. 21:35:07.886 WARN unknown The cached device pixel ratio value was stale on window expose. Please file a QTBUG which explains how to reproduce.