search

FedoraQt / QAdwaitaDecorations

Qt decoration plugin implementing Adwaita-like client-side decorations
GNU Lesser General Public License v2.1
72 stars 8 forks source link

Bottom and right 10 pixels of window are not clickable #48

Closed robxnano closed 9 months ago

robxnano commented 9 months ago

OS: Fedora Workstation 39

I found this when trying to increase the size of the window shadows. An area equal to ceShadowsWidth is not clickable on the bottom and right edges of the window. I think this might be an upstream Qt bug but I just wanted to check whether there's anything that can be done to fix it here.

grulja commented 9 months ago

Do you mean the area inside an app or outside where you can drag the window to resize it?

robxnano commented 9 months ago

The former. It's not obvious in most applications but the buttons on the bottom toolbar in KWrite show the problem. Only the top half is clickable.

grulja commented 9 months ago

Thanks for an example, I can reproduce now. It's probably a bug in QAdwaitaDecorations as I cannot reproduce it with bradient. Can you confirm it works with QT_WAYLAND_DECORATION=bradient kwrite?

robxnano commented 9 months ago

Yes it does work, but I think that's only because bradient doesn't have any shadows outside the normal window border. I made a potential fix over at https://codereview.qt-project.org/c/qt/qtwayland/+/527586, perhaps you could take a look and see if it looks right.

grulja commented 9 months ago

Yes it does work, but I think that's only because bradient doesn't have any shadows outside the normal window border. I made a potential fix over at https://codereview.qt-project.org/c/qt/qtwayland/+/527586, perhaps you could take a look and see if it looks right.

Looks good to me. I also tested it and it works. Thanks.

grulja commented 9 months ago

I'm going to close this issue here and backport your fix to Qt in Fedora.