Port QGnomePlatform to LibAdwaita look

[urFate]

Port QGnomePlatform to LibAdwaita look.

Audacious

PolyMC

[grulja]

Why did you remove shadows?

[urFate]

Why did you remove shadows?

I don't think shadows are suitable for a flat interface. There are also no shadows in Libadwaita applications (or they are so inconspicuous that they are not visible).

[grulja]

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

[urFate]

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

Something weird happened with clang-format check. This warnings are just comments and code which i didn't touch.

[grulja]

clang-format check failed, I guess you will have to remove all your formatting changes. I will check this change later, I don't run GNOME on daily basis and I will need to properly check how libadwaita looks like compared to the current design.

Something weird happened with clang-format check. This warnings are just comments and code which i didn't touch.

Yes, you did it here https://github.com/FedoraQt/QGnomePlatform/pull/116/commits/3e7ced5b8005ae788f90922f320d5c8837b002fe. There are unrelated formatting changes.

[urFate]

@grulja clang-format check seems like broken. Another PR in this repo also failing this check anyway.

[grulja]

@grulja clang-format check seems like broken. Another PR in this repo also failing this check anyway.

Should be fixed now, can you rebase?

[grulja]

Please, do a rebase, not a merge. You now have a merge commit in your history. Also, there are still unrelated coding style changes to the header file.

[urFate]

Please, do a rebase, not a merge. You now have a merge commit in your history. Also, there are still unrelated coding style changes to the header file.

Sorry for this incident. It is fixable?

[grulja]

You can squash some commits together and get rid of some changes using interactive rebase.

https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

You can then force push the changes.

[urFate]

@grulja Can you try run workflows?

[grulja]

Hi, I'm not sure I will be able to review this anytime soon, I will be taking vacation soon until the next year. One thing I'm also considering is to start working https://github.com/FedoraQt/QGnomePlatform/issues/121 as this would simplify lot of things and we would automatically support basically all kind of GTK themes with one codebase. In such case I don't think this, even in case it gets merged, would get released as most likely the next release I will do for QGnomePlaform will be with libdecor support. Will see. In any case I really appreciate your contribution and I'm sorry if this was useless.

[urFate]

Hi, I'm not sure I will be able to review this anytime soon, I will be taking vacation soon until the next year. One thing I'm also considering is to start working #121 as this would simplify lot of things and we would automatically support basically all kind of GTK themes with one codebase. In such case I don't think this, even in case it gets merged, would get released as most likely the next release I will do for QGnomePlaform will be with libdecor support. Will see. In any case I really appreciate your contribution and I'm sorry if this was useless.

It's okay, I just wanted my desktop to be combined with QT applications with Wayland. The last thing I thought about contributing to the project was. It will be great if the QGnomePlatform gets customization :)