search

FedoraQt / QGnomePlatform

QPlatformTheme for a better Qt application inclusion in GNOME
GNU Lesser General Public License v2.1
263 stars 38 forks source link

Fix build without shadows enabled #118

Closed polter-rnd closed 2 years ago

polter-rnd commented 2 years ago

Build without DECORATION_SHADOWS_SUPPORT was broken (at least with Qt 5.15 from Fedora). It also required some changes to get it work correctly.

Also added "Use more updated window state values" patch that existed in Fedora repos until 0.9 version -- I think it could be still useful when building without shadows (espetially it could be used for PR #116 to gracefully disable shadows if not needed)

polter-rnd commented 2 years ago

I see there's a build failure with Qt5 -- seems that CI uses vanilla 5.15.2 while I was trying of 5.15.7 from Fedora Rawhide which has backported QWaylandAbstractDecoration::margins(MarginsType marginsType = Full) from Qt6.

grulja commented 2 years ago

The support for shadows work either with patched Qt5 (Fedora → I did it there myself) and with Qt6. It is intentional so I'm not going to merge this change as it would break it for everyone using non-patched Qt5.

grulja commented 2 years ago

Also this https://github.com/qt/qtwayland/blob/dev/src/client/qwaylandwindow_p.h#L136 is missing in Qt 5.15. Looks we had that in Fedora backported before and I probably dropped it accidentally. I'll check. Either way, this is not something we are able to do here as the rest of the world doesn't have all the backports we have in Fedora.

grulja commented 2 years ago

Btw. I brought back the patch with updated states back to Fedora and pushed it here https://github.com/FedoraQt/QGnomePlatform/pull/119.