FedoraQt / QGnomePlatform

QPlatformTheme for a better Qt application inclusion in GNOME
GNU Lesser General Public License v2.1
262 stars 38 forks source link

0.9.0: build fails #122

Closed kloczek closed 1 year ago

kloczek commented 1 year ago

Looks like someting is wrong nas build fails with

[tkloczko@pers-jacek x86_64-redhat-linux-gnu]$ make -k
/usr/bin/cmake -S/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0 -B/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/CMakeFiles /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu//CMakeFiles/progress.marks
make  -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make  -f src/common/CMakeFiles/qgnomeplatform_autogen.dir/build.make src/common/CMakeFiles/qgnomeplatform_autogen.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0 /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/common /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common/CMakeFiles/qgnomeplatform_autogen.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make  -f src/common/CMakeFiles/qgnomeplatform_autogen.dir/build.make src/common/CMakeFiles/qgnomeplatform_autogen.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[  5%] Automatic MOC for target qgnomeplatform
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common && /usr/bin/cmake -E cmake_autogen /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common/CMakeFiles/qgnomeplatform_autogen.dir/AutogenInfo.json RelWithDebInfo
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[  5%] Built target qgnomeplatform_autogen
make  -f src/common/CMakeFiles/qgnomeplatform.dir/build.make src/common/CMakeFiles/qgnomeplatform.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0 /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/common /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/common/CMakeFiles/qgnomeplatform.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make  -f src/common/CMakeFiles/qgnomeplatform.dir/build.make src/common/CMakeFiles/qgnomeplatform.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make[2]: Nothing to be done for 'src/common/CMakeFiles/qgnomeplatform.dir/build'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[ 40%] Built target qgnomeplatform
make  -f src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/build.make src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0 /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make  -f src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/build.make src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[ 45%] Automatic MOC for target qgnomeplatformdecoration
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration && /usr/bin/cmake -E cmake_autogen /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration/CMakeFiles/qgnomeplatformdecoration_autogen.dir/AutogenInfo.json RelWithDebInfo
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[ 45%] Built target qgnomeplatformdecoration_autogen
make  -f src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/build.make src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0 /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/DependInfo.cmake --color=
Consolidate compiler generated dependencies of target qgnomeplatformdecoration
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
make  -f src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/build.make src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu'
[ 50%] Building CXX object src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/decorationplugin.cpp.o
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration && /usr/bin/g++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -Dqgnomeplatformdecoration_EXPORTS -I/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration/qgnomeplatformdecoration_autogen/include -I/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/common -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtGui/5.15.7 -isystem /usr/include/qt5/QtGui/5.15.7/QtGui -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore/5.15.7 -isystem /usr/include/qt5/QtCore/5.15.7/QtCore -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/harfbuzz -isystem /usr/include/cairo -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/atk-1.0 -isystem /usr/include/qt5/QtWaylandClient/5.15.7 -isystem /usr/include/qt5/QtWaylandClient/5.15.7/QtWaylandClient -isystem /usr/include/qt5/QtWaylandClient -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.7 -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.7/QtXkbCommonSupport -isystem /usr/include/qt5/QtXkbCommonSupport -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -fno-rtti -fno-exceptions -DNDEBUG -fPIC -fPIC -std=gnu++14 -MD -MT src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/decorationplugin.cpp.o -MF CMakeFiles/qgnomeplatformdecoration.dir/decorationplugin.cpp.o.d -o CMakeFiles/qgnomeplatformdecoration.dir/decorationplugin.cpp.o -c /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/decorationplugin.cpp
In file included from /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/decorationplugin.cpp:21:
/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.h:52:14: error: ‘QMargins QGnomePlatformDecoration::margins() const’ marked ‘override’, but does not override
   52 |     QMargins margins() const override;
      |              ^~~~~~~
/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/decorationplugin.cpp: In member function ‘virtual QtWaylandClient::QWaylandAbstractDecoration* QGnomePlatformDecorationPlugin::create(const QString&, const QStringList&)’:
/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/decorationplugin.cpp:27:45: error: invalid new-expression of abstract class type ‘QGnomePlatformDecoration’
   27 |         return new QGnomePlatformDecoration();
      |                                             ^
/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.h:42:7: note:   because the following virtual functions are pure within ‘QGnomePlatformDecoration’:
   42 | class QGnomePlatformDecoration : public QWaylandAbstractDecoration
      |       ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.h:23:
/usr/include/qt5/QtWaylandClient/5.15.7/QtWaylandClient/private/qwaylandabstractdecoration_p.h:100:22: note:     ‘virtual QMargins QtWaylandClient::QWaylandAbstractDecoration::margins(MarginsType) const’
  100 |     virtual QMargins margins(MarginsType marginsType = Full) const = 0;
      |                      ^~~~~~~
make[2]: *** [src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/build.make:93: src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/decorationplugin.cpp.o] Error 1
[ 55%] Building CXX object src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/qgnomeplatformdecoration.cpp.o
cd /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration && /usr/bin/g++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WAYLANDCLIENT_LIB -DQT_WIDGETS_LIB -DQT_XKBCOMMON_SUPPORT_LIB -Dqgnomeplatformdecoration_EXPORTS -I/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/x86_64-redhat-linux-gnu/src/decoration/qgnomeplatformdecoration_autogen/include -I/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/common -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtDBus -isystem /usr/include/qt5/QtGui/5.15.7 -isystem /usr/include/qt5/QtGui/5.15.7/QtGui -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore/5.15.7 -isystem /usr/include/qt5/QtCore/5.15.7/QtCore -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/harfbuzz -isystem /usr/include/cairo -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/atk-1.0 -isystem /usr/include/qt5/QtWaylandClient/5.15.7 -isystem /usr/include/qt5/QtWaylandClient/5.15.7/QtWaylandClient -isystem /usr/include/qt5/QtWaylandClient -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.7 -isystem /usr/include/qt5/QtXkbCommonSupport/5.15.7/QtXkbCommonSupport -isystem /usr/include/qt5/QtXkbCommonSupport -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -fno-rtti -fno-exceptions -DNDEBUG -fPIC -fPIC -std=gnu++14 -MD -MT src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/qgnomeplatformdecoration.cpp.o -MF CMakeFiles/qgnomeplatformdecoration.dir/qgnomeplatformdecoration.cpp.o.d -o CMakeFiles/qgnomeplatformdecoration.dir/qgnomeplatformdecoration.cpp.o -c /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.cpp
In file included from /home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.cpp:42:
/home/tkloczko/rpmbuild/BUILD/QGnomePlatform-0.9.0/src/decoration/qgnomeplatformdecoration.h:52:14: error: ‘QMargins QGnomePlatformDecoration::margins() const’ marked ‘override’, but does not override
   52 |     QMargins margins() const override;
      |              ^~~~~~~
make[2]: *** [src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/build.make:107: src/decoration/CMakeFiles/qgnomeplatformdecoration.dir/qgnomeplatformdecoration.cpp.o] Error 1

I'm using Qt 5.15.7 and gcc 12.x from Fedora rawhide.

grulja commented 1 year ago

You have to build with -DDECORATION_SHADOWS_SUPPORT=true on Fedora, this is because Fedora has backported some Qt6 changes for QtWayland that are not API compatible with original Qt5.

kloczek commented 1 year ago

Thx.