FedoraQt / adwaita-qt

A style to bend Qt applications to look like they belong into GNOME Shell
Other
488 stars 48 forks source link

Slide horizontal setting widgets in Krita #159

Closed bogdancovaciu closed 2 years ago

bogdancovaciu commented 2 years ago

Hello,

By default, the brush Opacity and Size widgets in Krita look like this:

image

With latest Adwaita-qt, kcoreaddons 5.87 and qt5 5.15.2 i get this:

image

The slide goes on vertical, squeezed, instead of horizontal.

Reproducible on KDE Plasma and Gnome while using the profile export KRITA_NO_STYLE_OVERRIDE=1 because i want to get rid of the default Fusion style used for it.

grulja commented 2 years ago

This is weird, because I have QProgressBar in my demo/test application and it is correct (both variants). Also, when I check the source code of QProgressBar, I can see that, when the orientation is horizontal, it updates QStyleOption->state, which is what we check in order to distinguish between horizontal and vertical orientation.

Have you seen similar issue in some other application?

bogdancovaciu commented 2 years ago

Actually Krita is the only one that has those Brush option sliders. Not sure if are related to QProgressBar, or simply something only they use for horizontalSlider > QSlider and doesn't match, only if using their default Fusion style or the Breeze one. Will try to contact one of the developers from Krita and see if i get a hint.

grulja commented 2 years ago

I will keep digging, because it works with Fusion and Breeze so there actually might be something wrong with Adwaita.

bogdancovaciu commented 2 years ago

The only real issue is when booting in Gnome, as i always test between KDE Plasma and Gnome, not mixing them, and i prefer to keep things consistent. But even in KDE Plasma i prefer to use Adwaita, has the best contrast for my eyes, and each element a proper "footprint" on screen. One thing i notice in preview, the difference of those sliders, but they render properly.

image

Only Krita has them somehow acting funky. Edit: Found only this on the bug report list https://bugs.kde.org/show_bug.cgi?id=440637

Not sure if related tho, or how that could influence the render of Adwaita.

grulja commented 2 years ago

Should be fixed with https://github.com/FedoraQt/adwaita-qt/commit/85670f8f2f61fd10f867d55555282d0951925160.