search

FedoraQt / adwaita-qt

A style to bend Qt applications to look like they belong into GNOME Shell
Other
488 stars 48 forks source link

Spinboxes #162

Open AlexB67 opened 2 years ago

AlexB67 commented 2 years ago

Okay, slider height slightly overdone, but much improved, tweak as you like.

AlexB67 commented 2 years ago

One final look EDIT: This is where the issue starts, you call

int frameWidth(pixelMetric(PM_SpinBoxFrameWidth, option, widget)); if (!flat) { size = expandSize(size, frameWidth); }

you are expanding your frame too much in height as a result, with changing the above to

int frameWidth(pixelMetric(PM_SpinBoxFrameWidth, option, widget)); if (!flat) { size = expandSize(size, frameWidth, 0); } gives the same height as per my previous change, so whatever way you cook it. You decide, but calling expandsize adds too much to the height. With the new change the result looks the same as per my previous change, but you can now call

size.setHeight(qMax(size.height(), int(Metrics::SpinBox_MinHeight)));

as before, and still get the improved result. having a careful look your other widgets are too tall also versus gtk, but negligible.

I'll check in my final changes tomorrow and leave it at that. I also did the slider ticks as per suggestion. Sorry not doing a new issue for it. Time is up.

Cheers .